Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT SUBMIT] Rc1.7.3 Test WebSocket Changes #4551

Closed
wants to merge 43 commits into from
Closed

[DO NOT SUBMIT] Rc1.7.3 Test WebSocket Changes #4551

wants to merge 43 commits into from

Conversation

HidyHan
Copy link
Contributor

@HidyHan HidyHan commented Oct 16, 2023

Reasons for making this change

Related issues

Screenshots

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

AndrewJGaut and others added 30 commits June 14, 2023 12:19
first commit
3221c90
@AndrewJGaut
Fix bugs
9c0ec8d
@AndrewJGaut
Fix more bugsz
a139498
@AndrewJGaut
slight change
b226f40
minor bug fixes
93f3e62
@AndrewJGaut
It's working quite well now
0db9264
@AndrewJGaut
merge conflict
1a65356
@AndrewJGaut
Update to solve that last bug. I think it should work now
ae3e3be
@AndrewJGaut
bug fix that was causing messages to be send to tall worker threads
85774a4
@AndrewJGaut
Fix unittests issue and fix formatting
81064a7
@AndrewJGaut
Minor change to increase robustness of message sending
5326420
@AndrewJGaut
Some more formatting changes
34550f0
@AndrewJGaut
Add in worker auth and use wss rather than ws for websocket URLs to m…
57aad3d 
…ake it secure. Not yet tested b/c on plane and internet isn't good enough to run CodaLab (and download images and such)
@AndrewJGaut
Added in server auth with secret. Aslo still need to test (still on p…
42127e5 
…lane)
@AndrewJGaut
Fixed issues and got auth working. Now, I'll work on returning error …
aa37b0e 
…codes so that we have proper tests
@AndrewJGaut
Add in tests for authentication functionality (for worker and server)
3e71d67
@AndrewJGaut
Slight cleanup to data sending code
7a0bd70
@AndrewJGaut
Adding in ssl certification
cbd1505
@AndrewJGaut
Add in SSL stuff for worker; still testing on dev
4eb3d7b
@AndrewJGaut
Revert "Add in SSL stuff for worker; still testing on dev"
aa74981 
This reverts commit 4eb3d7b.
@AndrewJGaut
Revert "Adding in ssl certification"
123fc7e 
This reverts commit cbd1505.
@AndrewJGaut
Fixed formatting
6efc0cf
@AndrewJGaut
Very minor formatting change to ignore one line for MyPy
35bdab0
@AndrewJGaut
Another minor formatting change
9f5417c
@AndrewJGaut
Merge branch 'master' into use-websockets-for-json-communication
f0ec0f1
@AndrewJGaut
add exponential backoff to see if that fixes dev issue
baf9121
@AndrewJGaut
Merge branch 'use-websockets-for-json-communication' of github.com:co…
6222950 
…dalab/codalab-worksheets into use-websockets-for-json-communication
@AndrewJGaut
Added code to actually detect worker disconnections now so that some …
100d536 
…websockets will be invalidated
@AndrewJGaut
Make sockets get looped over in random order to help distribute load
2a82155
@AndrewJGaut
Clean up ws-server and delete a Dataclass I was using previously
5dabf6d
AndrewJGaut and others added 13 commits July 16, 2023 21:34
@AndrewJGaut
a few more minor changes
0c57229
@AndrewJGaut
Make websocket locks more robust and improve error messaging
e34fb72
@AndrewJGaut
More permissible retries in case of other errors (e.g. like 1013). Wi…
42819a6 
…th exponential backoff, it's still not very aggressive at all
@AndrewJGaut
minor change to have a different error message if worker doesn't yet …
8e868a4 
…have any sockets open with ws-server
@AndrewJGaut
Rename send_json and send_json_message_with_sock
f36ed3a
@AndrewJGaut
Rearrange worker_model to minimize diff
4ed30a2
@AndrewJGaut
Final changes
d115a96
@AndrewJGaut
Fix formatting
5ac4853
@AndrewJGaut
Minor changes to get auth working again and to robustly return an err…
8acedff 
…or if the client tries to connect to an invalid path.
@AndrewJGaut
Merge branch 'master' of github.com:codalab/codalab-worksheets into u…
3d25b77 
…se-websockets-for-json-communication
@AndrewJGaut
Merge in master and make some minor changes
bbe9402
@HidyHan
test rc1.7.3
945028b
@HidyHan
Gets rid of unwanted tests.
9063ed1
@wwwjn wwwjn closed this Dec 14, 2023
@wwwjn wwwjn deleted the rc1.7.3 branch December 14, 2023 17:52
@wwwjn wwwjn restored the rc1.7.3 branch December 14, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HidyHan @wwwjn @AndrewJGaut