-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linked list tests #119
Linked list tests #119
Conversation
…erqueue function and a standalone test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd honestly much rather have a resizable array over linked lists one day so I am questioning the need of the linked lists themselves.
Also the need to the test the lists is not really that important more so in relation to images. Say, we add a image we delete a image and expect the list to look a certain way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I sort of get it but also this is not how the testing framework is supposed to be used.
Please take a look at the test.cpp
file so see how asserts are being used.
Well, this was more of an exercise for myself to practice different testing techniques, so it doesn't really add a lot of value to MLX I guess |
For now I won't merge this as mentioned for the reasons above. |
That's fair, it doesn't really add much value to MLX as it is |
I wrote some basic tests for the linked list functions, tbh it was more to practice a bit with testing