Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Close and Reopen conversation parts when conversation is closed or reopened #1378

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Add Close and Reopen conversation parts when conversation is closed or reopened #1378

wants to merge 6 commits into from

Commits on Dec 19, 2017

  1. change markup to more friendlier language

    @zacck
    zacck committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    fce56de View commit details
    Browse the repository at this point in the history

  2. add function to get name of user and pass the name into the email model

    @zacck
    zacck committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    195a634 View commit details
    Browse the repository at this point in the history

  3. add coverage for nil name checker and update model to use name

    @zacck
    zacck committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    f07cf77 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. merge upstream

    @zacck
    zacck committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    b2585e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of https://github.com/code-corps/code-corps-api … 

    …into develop
    @zacck
    zacck committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    11ed661 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Add test to check that reopened conversations get a converstationpart… 

    … with `part_type: "reopened"`

Add test to for conversation part when updated with a status of reopened

Add tests to check for a conversation_part when a conversation is updated with a status of closed

correct erronous field

add function clauses to handle adding closed and reopned conversation_parts

add reopened flag to possible statuses

add time information to body of closed and reopened event
    @zacck
    zacck committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    bb8f624 View commit details
    Browse the repository at this point in the history