feat: make portal-client dependency optional

code-pushup · Oct 11, 2024 · 7c7c826 · 7c7c826
1 parent 989dbec
commit 7c7c826
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/packages/core/src/lib/compare.ts b/packages/core/src/lib/compare.ts
@@ -13,7 +13,6 @@ import {
   calcDuration,
   ensureDirectoryExists,
   generateMdReportsDiff,
-  loadPortalClient,
   readJsonFile,
   scoreReport,
   ui,
@@ -25,6 +24,7 @@ import {
   compareCategories,
   compareGroups,
 } from './implementation/compare-scorables';
+import { loadPortalClient } from './load-portal-client';
 
 export async function compareReportFiles(
   inputPaths: Diff<string>,

diff --git a/packages/utils/src/lib/load-portal-client.ts → packages/core/src/lib/load-portal-client.ts b/packages/utils/src/lib/load-portal-client.ts → packages/core/src/lib/load-portal-client.ts
@@ -1,4 +1,4 @@
-import { ui } from './logging';
+import { ui } from '@code-pushup/utils';
 
 export async function loadPortalClient(): Promise<
   typeof import('@code-pushup/portal-client') | null

diff --git a/packages/core/src/lib/upload.ts b/packages/core/src/lib/upload.ts
@@ -1,7 +1,8 @@
 import type { SaveReportMutationVariables } from '@code-pushup/portal-client';
 import type { PersistConfig, Report, UploadConfig } from '@code-pushup/models';
-import { loadPortalClient, loadReport } from '@code-pushup/utils';
+import { loadReport } from '@code-pushup/utils';
 import { reportToGQL } from './implementation/report-to-gql';
+import { loadPortalClient } from './load-portal-client';
 import type { GlobalOptions } from './types';
 
 export type UploadOptions = { upload?: UploadConfig } & {

diff --git a/packages/utils/src/index.ts b/packages/utils/src/index.ts
@@ -120,4 +120,3 @@ export type {
   WithRequired,
 } from './lib/types';
 export { verboseUtils } from './lib/verbose-utils';
-export { loadPortalClient } from './lib/load-portal-client';
diff --git a/packages/utils/tsconfig.lib.json b/packages/utils/tsconfig.lib.json
@@ -5,7 +5,7 @@
     "declaration": true,
     "types": ["node"]
   },
-  "include": ["src/**/*.ts"],
+  "include": ["src/**/*.ts", "../core/src/lib/load-portal-client.ts"],
   "exclude": [
     "vite.config.unit.ts",
     "vite.config.integration.ts",