Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: model test refactor, models improvements, mock cleanup #405

Merged
merged 5 commits into from
Jan 12, 2024
Merged

chore: model test refactor, models improvements, mock cleanup #405

merged 5 commits into from
Jan 12, 2024

Conversation

Tlacenka
Copy link
Collaborator

@Tlacenka Tlacenka commented Jan 11, 2024 •
edited
Loading

Closes #143, #276, #254

This is the second part of models refactor:

  • I finished cleaning up models tests.
  • I migrated mocks to testing-utils.
  • I fixed models - plugins cannot be empty, missing reference correctly throws for empty audits array, packageName and version is correctly required.
  • Require slug for project and organization in upload configuration (otherwise the string is rejected by GraphQL).

@Tlacenka Tlacenka force-pushed the models-test-refactor-vol2 branch 2 times, most recently from 08236dd to 739b451 Compare January 12, 2024 10:35
This was linked to issues Jan 12, 2024
Folder structure for mocks and testing utils #276
Closed
models package test refactor #254
Closed
matejchalk
matejchalk reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

packages/models/src/lib/plugin-config.unit.test.ts Show resolved Hide resolved
packages/models/src/lib/category-config.unit.test.ts Show resolved Hide resolved
packages/models/src/lib/upload-config.ts Outdated Show resolved Hide resolved
@Tlacenka Tlacenka merged commit a38f520 into main Jan 12, 2024
18 checks passed
@Tlacenka Tlacenka deleted the models-test-refactor-vol2 branch January 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@BioPhoton BioPhoton Awaiting requested review from BioPhoton BioPhoton is a code owner

Assignees

@Tlacenka Tlacenka

Labels
🧩 core 🧩 lighthouse-plugin 🧩 models 🔬 testing writing tests 🧩 utils
Projects
None yet
Milestone
No milestone
2 participants
@Tlacenka @matejchalk