Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(utils): improve report folder structure, report function naming #408

Merged
merged 3 commits into from
Jan 12, 2024
Merged

chore(utils): improve report folder structure, report function naming #408

merged 3 commits into from
Jan 12, 2024

Conversation

Tlacenka
Copy link
Collaborator

Closes #262

This is the last package test refactor PR. In it, I do the following:

  • Fix remaining ESLint issues in test files.
  • Create a reports folder in utils for all entities related to reports.
  • Rename main functions to generateMdReport and generateStdoutSummary to reduce confusion (reportToStdout sounded like it already posted the report there).

@Tlacenka Tlacenka merged commit 973aac0 into main Jan 12, 2024
19 checks passed
@Tlacenka Tlacenka deleted the utils-refactor-vol-3 branch January 12, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@BioPhoton BioPhoton Awaiting requested review from BioPhoton BioPhoton is a code owner

Assignees

@Tlacenka Tlacenka

Labels
🧩 core 🧩 nx-plugin 🔬 testing writing tests 🧩 utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utils package test refactor
2 participants
@Tlacenka @matejchalk