Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli-e2e): move helper functions, clean up tests and setup #412

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Tlacenka
Copy link
Collaborator

Closes #41

I created a PR for E2E cleanup. Notable changes:

  • I introduced ESLint for the cli-e2e project.
  • I added help command test (until now only --help argument test was present).
  • I merged global setup (mock reset, timeout, tmp folder removal).
  • I removed print-config E2E test that was already covered by an integration test.
  • I prepared functions for a test folder management.

@Tlacenka Tlacenka self-assigned this Jan 15, 2024
@github-actions github-actions bot added the 🔬 testing writing tests label Jan 15, 2024
e2e/cli-e2e/tests/help.e2e.test.ts Outdated Show resolved Hide resolved
testing-utils/src/lib/setup/test-folder.setup.ts Outdated Show resolved Hide resolved
e2e/cli-e2e/mocks/fixtures/code-pushup.config.js Outdated Show resolved Hide resolved
e2e/cli-e2e/.eslintrc.json Outdated Show resolved Hide resolved
@Tlacenka Tlacenka merged commit b2b23d7 into main Jan 15, 2024
18 checks passed
@Tlacenka Tlacenka deleted the e2e-cleanup branch January 15, 2024 16:53
@Tlacenka Tlacenka added the 📈 conformance Linting, Formating, Benchmark label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 conformance Linting, Formating, Benchmark 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle test artefacts with cleanup and VFS where applicable
2 participants