Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): set fixed locale for date in report.md #428

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Jan 23, 2024

Closes #374 (cc @LayZeeDK)

@matejchalk matejchalk self-assigned this Jan 23, 2024
@matejchalk matejchalk added 🐛 bug something isn't working 🔬 testing writing tests 🧩 utils and removed 🧩 utils labels Jan 23, 2024
@github-actions github-actions bot removed the 🔬 testing writing tests label Jan 23, 2024
@github-actions github-actions bot added the 🔬 testing writing tests label Jan 23, 2024
@matejchalk matejchalk marked this pull request as ready for review January 23, 2024 09:57
Copy link
Contributor

@LayZeeDK LayZeeDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest change

Tlacenka
Tlacenka previously approved these changes Jan 24, 2024
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality looks good to me, tests added as well. ✔️
I looked at the latest CI results and verified that the correct date format was used. ✔️

vmasek
vmasek previously approved these changes Jan 24, 2024
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion

@matejchalk matejchalk dismissed stale reviews from vmasek and Tlacenka via 3dc2d08 January 24, 2024 16:53
@matejchalk matejchalk merged commit 1eaec07 into main Jan 24, 2024
18 checks passed
@matejchalk matejchalk deleted the fixed-english-date-locale branch January 24, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🔬 testing writing tests 🧩 utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[utils] integration test snapshot relies on en-US locale
5 participants