Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add upload timeout #429

Merged
merged 2 commits into from
Jan 24, 2024
Merged

feat(core): add upload timeout #429

merged 2 commits into from
Jan 24, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Jan 23, 2024

Long-running upload requests are unlikely to ever resolve past a certain interval. To prevent hanging CI jobs (which cost money), a default timeout of 5 minutes is set (in @code-pushup/portal-client - see https://github.com/code-pushup/portal/pull/230) after which upload will fail. This value is customizable via upload.timeout in config file.

Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the code and in combination with the portal-client changes, the pipeline should terminate after 5 minutes maximum.

packages/models/src/lib/upload-config.ts Show resolved Hide resolved
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matejchalk matejchalk merged commit fdc3f58 into main Jan 24, 2024
20 checks passed
@matejchalk matejchalk deleted the upload-timeout branch January 24, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants