-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-lighthouse): add lighthouse runner #549
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🔬 testing
writing tests
🧩 utils
🧩 lighthouse-plugin
🛠️ tooling
labels
Mar 8, 2024
BioPhoton
changed the title
Add lighthouse runner
feat(plugin-lighthouse): add lighthouse runner
Mar 8, 2024
# Conflicts: # packages/plugin-lighthouse/src/lib/utils.unit.test.ts
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a2153bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
github-actions
bot
added
the
📖 Project documentation
improvements or additions to the project documentation
label
Mar 8, 2024
This was referenced Mar 30, 2024
matejchalk
previously approved these changes
Apr 2, 2024
Tlacenka
reviewed
Apr 2, 2024
packages/plugin-lighthouse/src/lib/lighthouse-plugin.integration.test.ts
Outdated
Show resolved
Hide resolved
…on.test.ts Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Co-authored-by: Katka Pilátová <[email protected]>
Tlacenka
previously approved these changes
Apr 2, 2024
Tlacenka
previously approved these changes
Apr 2, 2024
Tlacenka
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🦾 CI/CD
continuous integration and deployment
🧩 lighthouse-plugin
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
🧩 utils
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps lighthouse core functionality exported as ESM with a
PluginRunner
for the@code-pushup/lighthouse-plugin
package.It aims to leverage all functionality directly over reusing their ESM exports instead of using the CLI.
This is less code to maintain as well as faster to execute and more scalable in terms of process arguments.
Changes included in this PR:
runLighthouse
, the core functionality of lighthouse. The following arguments are defined:url
,flags
andconfig
.getRunner
is implemented to get a lighthouse runner receiving theurl
,flags
andconfig
argumentsThe user is informed about missing implementations if by accident provided over the CLI flags or config object
flags
andconfig
objectCONTRIBUTING.md
to document setup and debugging of LighthouseFollow up PR:
Note
There is one thing left, I want to have the env variable only set for Windows in the CI.
References:
related to #90