Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add command option aliases #818

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

hanna-skryl
Copy link
Collaborator

Closes #672

This PR adds aliases for --onlyPlugins and --skipPlugins.

@hanna-skryl hanna-skryl self-assigned this Sep 18, 2024
@hanna-skryl
Copy link
Collaborator Author

hanna-skryl commented Sep 18, 2024

Using -c as an alias for --config is tricky. -c conflicts with Nx options and such options need to be wrapped into --args="..." to work (see more on this topic here).

If anyone knows how to use -c as an alias for --config without requiring users to wrap it within --args="...", I would appreciate any help!

UPD: It was decided during the discussion to keep the --config option without an alias.

Copy link

Code PushUp

😟 Code PushUp report has regressed – compared target commit 613308f with source commit 29c39ef.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 46 🔴 39 ↓ −6.5
Security 🟡 89 🟡 88 ↓ −0.8
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👎 2 groups regressed, 👎 6 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 46 🔴 39 ↓ −6.5
JS Packages NPM audit 🟡 89 🟡 88 ↓ −0.8

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.9 s 🟥 4.6 s ↑ +17.6 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 4.0 s ↑ +18.3 %
Lighthouse First Meaningful Paint 🟨 3.3 s 🟨 4.0 s ↑ +18.3 %
Lighthouse Speed Index 🟥 6.7 s 🟥 7.3 s ↑ +9.1 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 11 vulnerabilities (3 high, 8 moderate) 🟥 12 vulnerabilities (3 high, 9 moderate) ↑ +9.1 %
Lighthouse Time to Interactive 🟥 16.9 s 🟥 17.0 s ↑ +0.7 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,840 KiB 🟩 Total size was 1,836 KiB ↓ −0.2 %
Lighthouse Total Blocking Time 🟥 8,680 ms 🟥 7,870 ms ↓ −9.3 %
Lighthouse Max Potential First Input Delay 🟥 3,490 ms 🟥 4,160 ms ↑ +19.3 %
Lighthouse JavaScript execution time 🟥 10.7 s 🟥 10.2 s ↓ −4.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 23.1 s 🟥 22.8 s ↓ −1.3 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,530 ms 🟥 Potential savings of 1,720 ms ↑ +12.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 106 KiB 🟥 Potential savings of 106 KiB ↑ +50 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.7 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 70 ms ↑ +189.4 %
Lighthouse Initial server response time was short 🟩 Root document took 380 ms 🟩 Root document took 360 ms ↓ −4.6 %
Lighthouse Server Backend Latencies 🟩 220 ms 🟩 220 ms ↑ +0.6 %
Code coverage Line coverage 🟩 91.9 % 🟩 91.9 % ↑ +0.1 %

494 other audits are unchanged.

@hanna-skryl hanna-skryl merged commit 3ae1626 into main Sep 24, 2024
18 checks passed
@hanna-skryl hanna-skryl deleted the feat/add-command-option-aliases branch September 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aliases to command arguments
3 participants