Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): format reports with unchanged score #825

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

hanna-skryl
Copy link
Collaborator

@hanna-skryl hanna-skryl commented Sep 26, 2024

This PR resolves an issue with the report formatting logic where changes that did not affect the score were not being handled correctly. Specifically, it ensures that a categories table is excluded from the monorepo report when none of the category scores have been affected.

Closes #819

@hanna-skryl hanna-skryl self-assigned this Sep 26, 2024
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils labels Sep 26, 2024
Copy link

Code PushUp

🥳 Code PushUp report has improved – compared target commit c26c061 with source commit df5c5ac.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 35 🔴 48 ↑ +13.8
Code coverage 🟡 90 🟡 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Security 🟡 87 🟡 87
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 2 groups improved, 👍 7 audits improved, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 35 🔴 48 ↑ +13.8
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Meaningful Paint 🟥 4.5 s 🟨 3.0 s ↓ −32.4 %
Lighthouse Speed Index 🟥 10.1 s 🟥 6.1 s ↓ −39.6 %
Lighthouse First Contentful Paint 🟥 4.3 s 🟥 3.0 s ↓ −30 %
Lighthouse Largest Contentful Paint 🟥 5.0 s 🟨 3.7 s ↓ −24.8 %
Lighthouse Time to Interactive 🟥 21.3 s 🟥 16.7 s ↓ −21.7 %
Code coverage Branch coverage 🟨 84.9 % 🟨 85 % ↑ +0.1 %
Code coverage Line coverage 🟩 91.9 % 🟩 91.9 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 31.4 s 🟥 21.2 s ↓ −32.7 %
Lighthouse Total Blocking Time 🟥 14,440 ms 🟥 7,630 ms ↓ −47.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,807 KiB 🟩 Total size was 1,801 KiB ↓ −0.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −21.7 %
Lighthouse JavaScript execution time 🟥 14.5 s 🟥 10.4 s ↓ −28.4 %
Lighthouse Max Potential First Input Delay 🟥 5,380 ms 🟥 3,140 ms ↓ −41.7 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 860 ms 🟥 Potential savings of 1,300 ms ↑ +51.2 %
Lighthouse Network Round Trip Times 🟩 210 ms 🟩 30 ms ↓ −87.9 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 240 ms ↑ +75.8 %
Lighthouse Initial server response time was short 🟩 Root document took 420 ms 🟩 Root document took 350 ms ↓ −17.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 71 KiB 🟥 Potential savings of 57 KiB ↓ −3.2 %

494 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review September 26, 2024 21:29
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Reduced the irrelevant information.

@hanna-skryl hanna-skryl merged commit cddbdd3 into main Sep 30, 2024
20 checks passed
@hanna-skryl hanna-skryl deleted the fix/format-reports-with-unchanged-score branch September 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent empty categories table in PR comments
4 participants