Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-lighthouse): export default Chrome flags #832

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

hanna-skryl
Copy link
Collaborator

Closes #764

This pull request introduces DEFAULT_CHROME_FLAGS to @code-pushup/lighthouse-plugin, combining Chrome's default flags provided by chrome-launcher with --headless for streamlined headless execution.

The README has been updated to reflect this change.

@hanna-skryl hanna-skryl self-assigned this Oct 7, 2024
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 lighthouse-plugin labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit b0de9ad with source commit 149f54b.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Security 🟡 87 🟡 82 ↓ −5.1
Performance 🔴 48 🟡 52 ↑ +4.3
Code coverage 🟢 90 🟢 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 2 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM audit 🟡 87 🟡 82 ↓ −5.1
Lighthouse Performance 🔴 48 🟡 52 ↑ +4.3
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.1

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 7.6 s 🟥 6.2 s ↓ −18.2 %
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 3.3 s ↓ −8 %
JS Packages Vulnerabilities for NPM prod dependencies. 🟩 0 vulnerabilities 🟩 3 vulnerabilities (3 low) ↑ +∞ %
Lighthouse First Meaningful Paint 🟨 3.2 s 🟨 3.0 s ↓ −6.6 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟨 3.0 s ↓ −2 %
Lighthouse Time to Interactive 🟥 17.6 s 🟥 16.0 s ↓ −9.4 %
Code coverage Line coverage 🟩 91.5 % 🟩 91.5 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 25.0 s 🟥 20.1 s ↓ −19.7 %
Lighthouse Total Blocking Time 🟥 9,830 ms 🟥 5,940 ms ↓ −39.6 %
Lighthouse JavaScript execution time 🟥 11.3 s 🟥 9.2 s ↓ −18.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −9.4 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,819 KiB 🟩 Total size was 1,821 KiB ↑ +0.1 %
Lighthouse Max Potential First Input Delay 🟥 3,870 ms 🟥 2,850 ms ↓ −26.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 370 ms 🟥 Potential savings of 520 ms ↑ +38.4 %
Lighthouse Server Backend Latencies 🟩 270 ms 🟩 130 ms ↓ −51.6 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 490 ms ↑ +22 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 50 ms ↓ −31 %
Lighthouse Avoids an excessive DOM size 🟥 2,237 elements 🟥 2,236 elements ↓ −0.1 %

494 other audits are unchanged.

@hanna-skryl hanna-skryl force-pushed the feat/export-default-chrome-flags branch from 924d579 to 3d3ba8c Compare October 7, 2024 19:48
@hanna-skryl hanna-skryl marked this pull request as ready for review October 7, 2024 19:59
@hanna-skryl hanna-skryl requested a review from BioPhoton as a code owner October 7, 2024 19:59
@hanna-skryl hanna-skryl requested a review from matejchalk October 7, 2024 19:59
matejchalk
matejchalk previously approved these changes Oct 8, 2024
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

@hanna-skryl hanna-skryl merged commit 2518b6c into main Oct 8, 2024
16 of 17 checks passed
@hanna-skryl hanna-skryl deleted the feat/export-default-chrome-flags branch October 8, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 lighthouse-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(plugin-lighthouse): add defaultChromeFlag exports
3 participants