-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-lighthouse): export default Chrome flags #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit b0de9ad with source commit 149f54b. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 2 audits regressed, 12 audits changed without impacting score🗃️ Groups
17 other groups are unchanged. 🛡️ Audits
494 other audits are unchanged. |
924d579
to
3d3ba8c
Compare
BioPhoton
reviewed
Oct 7, 2024
matejchalk
previously approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement 👍
matejchalk
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧩 lighthouse-plugin
📖 Project documentation
improvements or additions to the project documentation
🔬 testing
writing tests
🛠️ tooling
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #764
This pull request introduces
DEFAULT_CHROME_FLAGS
to@code-pushup/lighthouse-plugin
, combining Chrome's default flags provided bychrome-launcher
with--headless
for streamlined headless execution.The README has been updated to reflect this change.