-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip perfect scores in stdout summary #833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared target commit 3e63aa8 with source commit 2518b6c. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score🗃️ Groups
17 other groups are unchanged. 🛡️ Audits
490 other audits are unchanged. |
matejchalk
reviewed
Oct 11, 2024
packages/utils/src/lib/reports/__snapshots__/report-stdout-all-perfect-scores.txt
Outdated
Show resolved
Hide resolved
packages/utils/src/lib/reports/log-stdout-summary.integration.test.ts
Outdated
Show resolved
Hide resolved
matejchalk
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #830
This pull request focuses on improving the terminal output by skipping audits with perfect scores and refactoring the code.
Changes:
verbose
option is now passed tologStdoutSummary
persistReport
tocollectAndPersistReports
logPlugins
is refactored to skip audits with perfect scores