Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip perfect scores in stdout summary #833

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

hanna-skryl
Copy link
Collaborator

Closes #830

This pull request focuses on improving the terminal output by skipping audits with perfect scores and refactoring the code.

Changes:

  • verbose option is now passed to logStdoutSummary
  • stdout logging is moved from persistReport to collectAndPersistReports
  • logPlugins is refactored to skip audits with perfect scores
  • test coverage is added

Copy link

github-actions bot commented Oct 10, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 3e63aa8 with source commit 2518b6c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 53 🔴 50 ↓ −3.2
Updates 🟡 78 🟡 77 ↓ −0.2
Code coverage 🟢 90 🟢 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Security 🟡 82 🟡 82
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 4 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 53 🔴 50 ↓ −3.2
JS Packages NPM outdated dependencies 🟡 78 🟡 77 ↓ −0.2
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.5 s ↑ +15.1 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟨 2.8 s ↓ −6.9 %
Lighthouse Speed Index 🟥 6.1 s 🟥 6.6 s ↑ +8.8 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟨 2.8 s ↓ −6.9 %
Lighthouse Time to Interactive 🟥 15.6 s 🟥 18.4 s ↑ +17.5 %
JS Packages Outdated NPM dev dependencies. 🟨 57 outdated package versions (32 major, 16 minor, 1 preminor, 7 patch, 1 prerelease) 🟨 58 outdated package versions (33 major, 16 minor, 1 preminor, 7 patch, 1 prerelease) ↑ +1.8 %
Code coverage Branch coverage 🟨 85.3 % 🟨 85.4 % ↑ +0.1 %
Code coverage Function coverage 🟩 92.4 % 🟩 92.4 % ↑ +0.1 %
Code coverage Line coverage 🟩 91.5 % 🟩 91.5 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,824 KiB 🟩 Total size was 1,821 KiB ↓ −0.2 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +17.5 %
Lighthouse JavaScript execution time 🟥 9.2 s 🟥 11.7 s ↑ +27.4 %
Lighthouse Minimizes main-thread work 🟥 20.1 s 🟥 22.3 s ↑ +10.7 %
Lighthouse Total Blocking Time 🟥 6,730 ms 🟥 8,270 ms ↑ +22.9 %
Lighthouse Max Potential First Input Delay 🟥 2,470 ms 🟥 3,800 ms ↑ +53.9 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,220 ms 🟥 Potential savings of 320 ms ↓ −74.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 35 KiB ↓ −50 %
Lighthouse Initial server response time was short 🟩 Root document took 430 ms 🟩 Root document took 510 ms ↑ +18.9 %
Lighthouse Server Backend Latencies 🟩 200 ms 🟩 170 ms ↓ −15.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,241 elements 🟥 2,249 elements ↑ +0.4 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 70 ms ↑ +8.8 %
Lighthouse Avoid non-composited animations 🟩 14 animated elements found 🟩 0 ↓ −100 %

490 other audits are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review October 10, 2024 23:17
@hanna-skryl hanna-skryl merged commit f423c6c into main Oct 11, 2024
15 of 17 checks passed
@hanna-skryl hanna-skryl deleted the feat/skip-perfect-scores-in-stdout-summary branch October 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip perfect scores in stdout summary
2 participants