Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove npm audit from CI #838

Merged
merged 1 commit into from
Oct 14, 2024
Merged

build: remove npm audit from CI #838

merged 1 commit into from
Oct 14, 2024

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Oct 14, 2024

The code pushup js check NPM audit packages plugin now

it is checked by code pushup js packages plugin now

Signed-off-by: Vojtech Masek <[email protected]>
@github-actions github-actions bot added the 🦾 CI/CD continuous integration and deployment label Oct 14, 2024
@vmasek vmasek added 🚨 Hotfix Hotfix PR/issue and removed 🦾 CI/CD continuous integration and deployment labels Oct 14, 2024
@vmasek vmasek enabled auto-merge (rebase) October 14, 2024 13:42
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 9aafc9d with source commit f423c6c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 42 ↓ −12.6
Custom checks 🟡 67 🟡 67
Code coverage 🟢 90 🟢 90
Security 🟡 82 🟡 82
Updates 🟡 77 🟡 77
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👎 1 group regressed, 👍 1 audit improved, 👎 4 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 42 ↓ −12.6

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟨 Potential savings of 70 KiB ↓ −100 %
Lighthouse Speed Index 🟨 5.3 s 🟥 7.7 s ↑ +44.5 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟥 4.2 s ↑ +33.9 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟥 3.6 s ↑ +20.9 %
Lighthouse First Meaningful Paint 🟨 3.0 s 🟨 3.6 s ↑ +20.9 %
Lighthouse Total Blocking Time 🟥 9,880 ms 🟥 11,950 ms ↑ +20.9 %
Lighthouse Minimizes main-thread work 🟥 24.0 s 🟥 25.6 s ↑ +6.5 %
Lighthouse Max Potential First Input Delay 🟥 4,220 ms 🟥 2,670 ms ↓ −36.8 %
Lighthouse JavaScript execution time 🟥 12.0 s 🟥 13.2 s ↑ +9.9 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,070 ms 🟥 Potential savings of 70 ms ↓ −93.8 %
Lighthouse Time to Interactive 🟥 18.1 s 🟥 19.1 s ↑ +5.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +5.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,820 KiB 🟩 Total size was 1,821 KiB ↑ +0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 80 ms ↑ +421.5 %
Lighthouse Initial server response time was short 🟩 Root document took 390 ms 🟩 Root document took 410 ms ↑ +5.3 %
Lighthouse Server Backend Latencies 🟩 80 ms 🟩 100 ms ↑ +18.1 %

496 other audits are unchanged.

@vmasek vmasek merged commit c420a68 into main Oct 14, 2024
17 checks passed
@vmasek vmasek deleted the remove-deps-audit branch October 14, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 Hotfix Hotfix PR/issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants