Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): new package with code extracted from github-action #839

Merged
merged 18 commits into from
Oct 15, 2024

Conversation

matejchalk
Copy link
Collaborator

Bulk of #829

See new package's README.

@matejchalk matejchalk added the ➕ enhancement new feature or request label Oct 14, 2024
@matejchalk matejchalk self-assigned this Oct 14, 2024
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling labels Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 4713a4b with source commit 12ecf6a.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 47 🟡 55 ↑ +7.8
Updates 🟡 77 🟡 75 ↓ −2.1
Security 🟡 82 🟡 82 ↑ +0.8
Code coverage 🟢 90 🟡 90 ↓ −0.3
Custom checks 🟡 67 🟡 67
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 2 groups improved, 👎 2 groups regressed, 👍 7 audits improved, 👎 4 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 47 🟡 55 ↑ +7.8
JS Packages NPM outdated dependencies 🟡 77 🟡 75 ↓ −2.1
JS Packages NPM audit 🟡 82 🟡 82 ↑ +0.8
Code coverage Code coverage metrics 🟢 90 🟡 90 ↓ −0.3

16 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 3.0 s ↓ −17.7 %
Lighthouse Speed Index 🟥 7.2 s 🟥 5.9 s ↓ −18 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟨 2.8 s ↓ −13.9 %
Lighthouse First Meaningful Paint 🟨 3.3 s 🟨 2.8 s ↓ −13.9 %
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 13 vulnerabilities (4 high, 9 moderate) 🟥 12 vulnerabilities (4 high, 8 moderate) ↓ −7.7 %
Lighthouse Time to Interactive 🟥 20.1 s 🟥 16.8 s ↓ −16.4 %
JS Packages Outdated NPM prod dependencies. 🟨 13 outdated package versions (4 major, 4 minor, 5 patch) 🟨 15 outdated package versions (5 major, 5 minor, 5 patch) ↑ +15.4 %
Code coverage Line coverage 🟩 91.5 % 🟩 90.7 % ↓ −0.9 %
JS Packages Outdated NPM dev dependencies. 🟨 58 outdated package versions (33 major, 16 minor, 1 preminor, 7 patch, 1 prerelease) 🟨 58 outdated package versions (33 major, 16 minor, 1 preminor, 7 patch, 1 prerelease)  +0 %
Code coverage Branch coverage 🟨 85.3 % 🟨 84.8 % ↓ −0.6 %
Code coverage Function coverage 🟩 92.4 % 🟩 92.3 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 25.7 s 🟥 19.4 s ↓ −24.6 %
Lighthouse Total Blocking Time 🟥 12,520 ms 🟥 6,750 ms ↓ −46.1 %
Lighthouse JavaScript execution time 🟥 14.3 s 🟥 9.1 s ↓ −36.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −16.4 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 180 ms 🟥 Potential savings of 910 ms ↑ +407.8 %
Lighthouse Max Potential First Input Delay 🟥 4,000 ms 🟥 3,310 ms ↓ −17.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 70 KiB ↑ +∞ %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,825 KiB 🟩 Total size was 1,825 KiB ↓ −0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 80 ms 🟩 200 ms ↑ +141.1 %
Lighthouse Network Round Trip Times 🟩 120 ms 🟩 70 ms ↓ −46.2 %
Lighthouse Initial server response time was short 🟩 Root document took 470 ms 🟩 Root document took 450 ms ↓ −5.2 %
Lighthouse Avoids an excessive DOM size 🟥 2,246 elements 🟥 2,247 elements ↑ +0.1 %

489 other audits are unchanged.

packages/ci/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitlab integration ahead it seems! Nice you started this PR.
More unit tests and some integration tests would round it up. :)

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩🚀🚀

@matejchalk matejchalk merged commit 138e180 into main Oct 15, 2024
16 checks passed
@matejchalk matejchalk deleted the ci-package branch October 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ enhancement new feature or request 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🛠️ tooling 🧩 utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants