Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move metadata into each of the sub-package package.json and add keywords #846

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

vmasek
Copy link
Collaborator

@vmasek vmasek commented Oct 16, 2024

closes #848

  • remove esbuild post build step transforming sub-package package.jsons
  • move all necessary metadata into each of the sub-package package.jsons
  • add keywords to all sub-package package.jsons
    • NPM displays keywords and uses them for search categorizing, I've added a few so our package is more visible

Copy link

github-actions bot commented Oct 16, 2024

Code PushUp

😟 Code PushUp report has regressed – compared target commit 45b166e with source commit 13a63a4.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 48 ↓ −5.7
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Updates 🟡 75 🟡 75
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 1 group regressed, 👎 5 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 48 ↓ −5.7

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.7 s ↑ +17.5 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟥 3.1 s ↑ +14.7 %
Lighthouse First Meaningful Paint 🟨 2.7 s 🟨 3.2 s ↑ +17.5 %
Lighthouse Speed Index 🟥 6.1 s 🟥 6.3 s ↑ +3.9 %
Lighthouse Time to Interactive 🟥 16.3 s 🟥 17.8 s ↑ +9.1 %
Lighthouse Minimizes main-thread work 🟥 17.3 s 🟥 22.7 s ↑ +31.4 %
Lighthouse Total Blocking Time 🟥 5,990 ms 🟥 7,680 ms ↑ +28.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +9.1 %
Lighthouse JavaScript execution time 🟥 9.3 s 🟥 10.5 s ↑ +12.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,808 KiB 🟩 Total size was 1,807 KiB ↓ −0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Max Potential First Input Delay 🟥 3,370 ms 🟥 3,650 ms ↑ +8.6 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 770 ms 🟥 Potential savings of 940 ms ↑ +22.9 %
Lighthouse Network Round Trip Times 🟩 40 ms 🟩 20 ms ↓ −47.8 %
Lighthouse Initial server response time was short 🟩 Root document took 320 ms 🟩 Root document took 340 ms ↑ +4 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 150 ms ↑ +8.8 %
Lighthouse Avoid large layout shifts 🟩 0 🟩 1 layout shift found ↑ +∞ %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0.001 ↑ +∞ %

495 other audits are unchanged.

@vmasek vmasek changed the title feat: add keywords for NPM to display refactor: move metadata into each of the sub-package package.json and add keywords Oct 16, 2024
@vmasek vmasek changed the title refactor: move metadata into each of the sub-package package.json and add keywords refactor: move metadata into each of the sub-package package.json and add keywords Oct 16, 2024
@vmasek vmasek requested a review from matejchalk October 16, 2024 15:57
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Oct 16, 2024
@vmasek vmasek requested a review from matejchalk October 17, 2024 13:22
populate all sub-packages with required metadata
closes #848

Signed-off-by: Vojtech Masek <[email protected]>
@vmasek vmasek enabled auto-merge (rebase) October 17, 2024 13:24
@vmasek vmasek merged commit f01bcc4 into main Oct 17, 2024
13 of 16 checks passed
@vmasek vmasek deleted the package-keywords branch October 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Project documentation improvements or additions to the project documentation 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor sub-package package.json metadata
2 participants