Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avoid portal-client import for enum conversions #850

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

matejchalk
Copy link
Collaborator

Related:

Ran into error when @code-pushup/cli installed without @code-pushup/portal-client. There was a leftover static non-type import for converting CLI reports to portal. Came up with a type-safe way to not have to use the enum objects.

@matejchalk matejchalk self-assigned this Oct 16, 2024
@matejchalk matejchalk added 🐛 bug something isn't working 🧩 core labels Oct 16, 2024
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 937a322 with source commit f2744fd.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 50 🟡 55 ↑ +4.3
Code coverage 🟡 90 🟡 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Security 🟡 82 🟡 82
Updates 🟡 75 🟡 75
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
👍 2 groups improved, 👍 4 audits improved, 👎 2 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 50 🟡 55 ↑ +4.3
Code coverage Code coverage metrics 🟡 90 🟡 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟥 3.1 s 🟨 2.7 s ↓ −14.5 %
Lighthouse Largest Contentful Paint 🟨 3.3 s 🟨 2.8 s ↓ −13.8 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟨 2.8 s ↓ −12.1 %
Lighthouse Speed Index 🟥 7.0 s 🟥 7.3 s ↑ +4.2 %
Lighthouse Time to Interactive 🟥 16.3 s 🟥 19.1 s ↑ +16.9 %
Code coverage Function coverage 🟩 92.4 % 🟩 92.4 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 20.6 s 🟥 26.1 s ↑ +26.9 %
Lighthouse Total Blocking Time 🟥 7,180 ms 🟥 12,230 ms ↑ +70.4 %
Lighthouse JavaScript execution time 🟥 9.3 s 🟥 12.1 s ↑ +30.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +16.9 %
Lighthouse Max Potential First Input Delay 🟥 2,500 ms 🟥 3,540 ms ↑ +41.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,822 KiB 🟩 Total size was 1,822 KiB ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 470 ms 🟥 Potential savings of 360 ms ↓ −24.6 %
Lighthouse Server Backend Latencies 🟩 150 ms 🟩 90 ms ↓ −43.3 %
Lighthouse Initial server response time was short 🟩 Root document took 530 ms 🟩 Root document took 480 ms ↓ −10.7 %
Lighthouse Network Round Trip Times 🟩 80 ms 🟩 20 ms ↓ −71.6 %
Code coverage Line coverage 🟩 90.7 % 🟩 90.7 % ↑ +0.1 %
Code coverage Branch coverage 🟨 84.8 % 🟨 84.8 % ↑ +0.1 %

494 other audits are unchanged.

@matejchalk matejchalk merged commit 1a68636 into main Oct 17, 2024
14 of 17 checks passed
@matejchalk matejchalk deleted the fix-portal-client-enum-imports branch October 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants