Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add knip core logic #4

Merged
merged 19 commits into from
Jan 12, 2025
Merged

feat: add knip core logic #4

merged 19 commits into from
Jan 12, 2025

Conversation

BioPhoton
Copy link
Collaborator

No description provided.

BioPhoton
BioPhoton commented Jan 12, 2025
View reviewed changes
Copy link
Collaborator Author

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

aramirezj
aramirezj approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@aramirezj aramirezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BioPhoton BioPhoton requested a review from aramirezj January 12, 2025 19:24
aramirezj
aramirezj approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@aramirezj aramirezj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramirezj aramirezj merged commit 2d294e8 into main Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramirezj aramirezj aramirezj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BioPhoton @aramirezj