Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve logging and remove try/catch block #146

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix: improve logging and remove try/catch block #146

merged 1 commit into from
Feb 28, 2025

Conversation

vmasek
Copy link
Contributor

@vmasek vmasek commented Feb 28, 2025

No description provided.

Copy link

github-actions bot commented Feb 28, 2025

Code PushUp

🥳 Code PushUp report has improved – compared current commit bce83fd with previous commit efd7f1e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 60 🟡 62 ↑ +1.6
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Security 🔴 29 🔴 29
Updates 🟢 98 🟢 98
👍 1 group improved, 👍 3 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 60 🟡 62 ↑ +1.6

11 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟥 36.6 % 🟥 39.7 % ↑ +8.5 %
Code coverage Line coverage 🟨 55.6 % 🟨 56.5 % ↑ +1.7 %
Code coverage Function coverage 🟨 72.4 % 🟨 73.3 % ↑ +1.3 %

169 other audits are unchanged.

@vmasek vmasek marked this pull request as ready for review February 28, 2025 10:20
@vmasek vmasek requested a review from matejchalk as a code owner February 28, 2025 10:20
@vmasek
Copy link
Contributor Author

vmasek commented Feb 28, 2025

@matejchalk I took you change of removing try/catch block as it really is what was blocking the error from being displayed and adjusted the logging setup so we always get the most info on verbose/debug run.

I am setting options.debug to true as this gets picked up both locally and via env variable and enables debug behavior without a need of re-run

@vmasek vmasek merged commit 4b1819c into main Feb 28, 2025
24 checks passed
@vmasek vmasek deleted the logging branch February 28, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants