fix(cli): missing failure counts when there is failedHooks (#4633)

codeceptjs · Dec 11, 2024 · 3e6415c · 3e6415c
1 parent 831f13e
commit 3e6415c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/cli.js b/lib/cli.js
@@ -219,7 +219,6 @@ class Cli extends Base {
 
     this.failures.forEach((failure) => {
       if (failure.constructor.name === 'Hook') {
-        stats.failures -= stats.failures
         stats.failedHooks += 1
       }
     })

diff --git a/test/runner/before_failure_test.js b/test/runner/before_failure_test.js
@@ -12,7 +12,7 @@ describe('Failure in before', function () {
       stdout.should.include('First test will be passed @grep')
       stdout.should.include('Third test will be skipped @grep')
       stdout.should.include('Fourth test will be skipped')
-      stdout.should.include('1 passed, 1 failedHooks, 2 skipped')
+      stdout.should.include('1 passed, 1 failed, 1 failedHooks, 2 skipped')
       err.code.should.eql(1)
       done()
     })
@@ -22,7 +22,7 @@ describe('Failure in before', function () {
     exec(`${codecept_run} --grep @grep`, (err, stdout) => {
       stdout.should.include('First test will be passed @grep')
       stdout.should.include('Third test will be skipped @grep')
-      stdout.should.include('1 passed, 1 failedHooks, 1 skipped')
+      stdout.should.include('1 passed, 1 failed, 1 failedHooks, 1 skipped')
       err.code.should.eql(1)
       done()
     })

diff --git a/test/runner/run_workers_test.js b/test/runner/run_workers_test.js
@@ -44,7 +44,8 @@ describe('CodeceptJS Workers Runner', function () {
       expect(stdout).not.toContain('this is running inside worker')
       expect(stdout).toContain('failed')
       expect(stdout).toContain('File notafile not found')
-      expect(stdout).toContain('5 passed, 1 failed, 1 failedHooks')
+      expect(stdout).toContain('Scenario Steps:')
+      expect(stdout).toContain('5 passed, 2 failed, 1 failedHooks')
       // We are not testing order in logs, because it depends on race condition between workers
       expect(stdout).toContain(') Workers Failing\n') // first fail log
       expect(stdout).toContain(') Workers\n') // second fail log