Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov Pull urls gives 404 response unless authenticated #631

Closed
joeyjurjens opened this issue Jan 22, 2025 · 4 comments
Closed

Codecov Pull urls gives 404 response unless authenticated #631

joeyjurjens opened this issue Jan 22, 2025 · 4 comments

Comments

@joeyjurjens
Copy link

Describe the bug
Recently, the urls that codecov generates from pull requests are giving a 404 response.

If not logged in with GitHub, this happens. It used to be that everyone could access this.

Happens in all browsers for me.

At first I thought I had to use a global upload token

To Reproduce

  1. Go to; https://app.codecov.io/gh/django-oscar/django-oscar/pull/4424?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-oscar
  2. You will get a 404 (and otherwise try incognito)

Expected behavior
Being able to see the report with the provided link

Screenshots

Image

Additional context

When going to a pull link, I also saw this banner;

Your org no longer requires upload tokens.
You can upload without a token. Contact your admins to manage the global upload token settings.

And when logged in into codecov with my account, it says;

You must now upload using a token.
Upload with eitherthe global upload token
or the repo upload token. Admins can manage the
[global upload token settings.](https://app.codecov.io/account/gh/django-oscar/org-upload-token)

We have the Codecov GitHub app installed, that used to work just fine (as it still uploads). But I tried doing it with a global token in this PR;
https://app.codecov.io/gh/django-oscar/django-oscar/pull/4427?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=django-oscar

But then it is still giving me a 404.

So if the GitHub app is still a valid approach, I'll not merge that PR but would love to hear about that too.

@covecod covecod bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Jan 22, 2025
@joeyjurjens
Copy link
Author

joeyjurjens commented Jan 24, 2025 via email

@nicholas-codecov
Copy link

Hi @joeyjurjens this should be resolved once this changed is deployed: codecov/gazebo#3679

@joeyjurjens
Copy link
Author

Hi @joeyjurjens this should be resolved once this changed is deployed: codecov/gazebo#3679

Seems to be resolved indeed. Thank you!

@covecod covecod bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Jan 24, 2025
@nicholas-codecov
Copy link

Okay perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

2 participants