-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PullCoverage a passing null instead of boolean #3679
Conversation
Bundle ReportChanges will increase total bundle size by 12.42MB (100.0%) ⬆️
|
Bundle ReportChanges will increase total bundle size by 23 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3679 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14892
Branches 4241 4233 -8
=======================================
Hits 14716 14716
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3679 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14892
Branches 4241 4241
=======================================
Hits 14716 14716
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3679 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14892
Branches 4233 4241 +8
=======================================
Hits 14716 14716
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3679 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14892
Branches 4241 4233 -8
=======================================
Hits 14716 14716
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
This PR fixes this Sentry issue, and should also resolve this ticket.
Notable Changes
PullCoverage
to TS and make sure to pass a booleanindex
and tests to TS