Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PullCoverage a passing null instead of boolean #3679

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR fixes this Sentry issue, and should also resolve this ticket.

Notable Changes

  • Refactor PullCoverage to TS and make sure to pass a boolean
  • Refactor index and tests to TS

@codecov-staging
Copy link

codecov-staging bot commented Jan 24, 2025

Bundle Report

Changes will increase total bundle size by 12.42MB (100.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
gazebo-staging-system 6.19MB 6.19MB (100%) ⬆️⚠️
gazebo-staging-esm 6.24MB 6.24MB (100%) ⬆️⚠️

Copy link

codecov bot commented Jan 24, 2025

Bundle Report

Changes will increase total bundle size by 23 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.19MB 6 bytes (0.0%) ⬆️
gazebo-production-esm 6.24MB 17 bytes (0.0%) ⬆️

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (b7ce614) to head (062376d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3679   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14892    14892           
  Branches     4241     4233    -8     
=======================================
  Hits        14716    14716           
  Misses        167      167           
  Partials        9        9           
Files with missing lines Coverage Δ
...ages/PullRequestPage/PullCoverage/PullCoverage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (ø)
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ce614...062376d. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3679   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14892    14892           
  Branches     4241     4241           
=======================================
  Hits        14716    14716           
  Misses        167      167           
  Partials        9        9           
Files with missing lines Coverage Δ
...ages/PullRequestPage/PullCoverage/PullCoverage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (ø)
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ce614...062376d. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (b7ce614) to head (062376d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3679   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14892    14892           
  Branches     4233     4241    +8     
=======================================
  Hits        14716    14716           
  Misses        167      167           
  Partials        9        9           
Files with missing lines Coverage Δ
...ages/PullRequestPage/PullCoverage/PullCoverage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (ø)
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ce614...062376d. Read the comment docs.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov-public-qa bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (b7ce614) to head (062376d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3679   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14892    14892           
  Branches     4241     4233    -8     
=======================================
  Hits        14716    14716           
  Misses        167      167           
  Partials        9        9           
Files with missing lines Coverage Δ
...ages/PullRequestPage/PullCoverage/PullCoverage.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (ø)
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ce614...062376d. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
062376d Fri, 24 Jan 2025 17:42:53 GMT Cloud Enterprise

Merged via the queue into main with commit 9a77add Jan 24, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-issue-with-PullPageDataQueryOpts branch January 24, 2025 17:43
Copy link

sentry-io bot commented Jan 27, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Importing a module script failed. /:provider/:owner/:repo/pull/:pullId View Issue
  • ‼️ TypeError: Failed to fetch /:provider/:owner/:repo/pull/:pullId View Issue
  • ‼️ TypeError: NetworkError when attempting to fetch resource. /:provider/:owner/:repo/pull/:pullId View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants