Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is repo public bug #3669

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Is repo public bug #3669

merged 2 commits into from
Jan 20, 2025

Conversation

RulaKhaled
Copy link
Contributor

Description

We replaced the check for tier names with isTeamPlan, resulting in a false default for isPublic for signed in users

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@RulaKhaled RulaKhaled enabled auto-merge January 20, 2025 10:58
@RulaKhaled RulaKhaled disabled auto-merge January 20, 2025 10:59
@codecov-notifications
Copy link

codecov-notifications bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3669   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14714    14716    +2     
  Branches     4171     4173    +2     
=======================================
+ Hits        14555    14557    +2     
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/Chart/useCoverage.ts 100.00% <100.00%> (ø)
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (+<0.01%) ⬆️
Services 99.28% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f9710...15702a4. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (66f9710) to head (15702a4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3669   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14714    14716    +2     
  Branches     4163     4165    +2     
=======================================
+ Hits        14555    14557    +2     
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/Chart/useCoverage.ts 100.00% <100.00%> (ø)
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (+<0.01%) ⬆️
Services 99.28% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f9710...15702a4. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (66f9710) to head (40dee26).

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3669   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14714    14715    +1     
  Branches     4171     4172    +1     
=======================================
+ Hits        14555    14556    +1     
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <ø> (ø)
Services 99.28% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f9710...40dee26. Read the comment docs.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (66f9710) to head (15702a4).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3669   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         817      817           
  Lines       14714    14716    +2     
  Branches     4163     4165    +2     
=======================================
+ Hits        14555    14557    +2     
  Misses        152      152           
  Partials        7        7           
Files with missing lines Coverage Δ
src/pages/AnalyticsPage/Chart/useCoverage.ts 100.00% <100.00%> (ø)
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx 100.00% <100.00%> (ø)
src/shared/ListRepo/ReposTable/ReposTable.tsx 98.61% <100.00%> (+0.01%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.62% <100.00%> (+<0.01%) ⬆️
Services 99.28% <ø> (ø)
Shared 99.37% <100.00%> (+<0.01%) ⬆️
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f9710...15702a4. Read the comment docs.

@RulaKhaled RulaKhaled enabled auto-merge January 20, 2025 11:02
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 20, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
15702a4 Mon, 20 Jan 2025 11:02:37 GMT Expired Expired
15702a4 Mon, 20 Jan 2025 11:07:04 GMT Cloud Enterprise

@RulaKhaled RulaKhaled added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 8480fc7 Jan 20, 2025
61 checks passed
@RulaKhaled RulaKhaled deleted the is-repo-public-bug branch January 20, 2025 11:09
Copy link

codecov bot commented Jan 20, 2025

Bundle Report

Changes will increase total bundle size by 61 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.05MB 31 bytes (0.0%) ⬆️
gazebo-production-esm 6.1MB 30 bytes (0.0%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants