feat: Add img component for light and dark src #3675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3675 +/- ##
==========================================
- Coverage 98.79% 98.79% -0.01%
==========================================
Files 824 825 +1
Lines 14812 14808 -4
Branches 4206 4195 -11
==========================================
- Hits 14633 14629 -4
Misses 170 170
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3675 +/- ##
==========================================
- Coverage 98.79% 98.79% -0.01%
==========================================
Files 824 825 +1
Lines 14812 14808 -4
Branches 4206 4195 -11
==========================================
- Hits 14633 14629 -4
Misses 170 170
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 25 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3675 +/- ##
==========================================
- Coverage 98.79% 98.79% -0.01%
==========================================
Files 824 825 +1
Lines 14812 14808 -4
Branches 4206 4203 -3
==========================================
- Hits 14633 14629 -4
Misses 170 170
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| const renderWithTheme = (ui: React.ReactElement, theme: Theme) => { | ||
| return render( | ||
| <ThemeContext.Provider value={{ theme, setTheme: vi.fn() }}> | ||
| {ui} | ||
| </ThemeContext.Provider> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Thoughts on converting this to a wrapper component, similar to how we do it in other tests?
Bundle ReportChanges will increase total bundle size by 25 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3675 +/- ##
========================================
Coverage 98.80% 98.81%
========================================
Files 820 826 +6
Lines 14784 14888 +104
Branches 4206 4238 +32
========================================
+ Hits 14608 14712 +104
Misses 167 167
Partials 9 9
... and 20 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
calvin-codecov
force-pushed
the
cy/light_dark_switch
branch
from
88878f0 to
eb09ae5
Compare
calvin-codecov
force-pushed
the
cy/light_dark_switch
branch
from
eb09ae5 to
609cb2e
Compare
Description
Closes codecov/engineering-team#2812
Code Example
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.