fix: Hide tokenless banner for signed out user #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 44 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 825 825
Lines 14806 14813 +7
Branches 4201 4198 -3
=======================================
+ Hits 14626 14633 +7
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 825 825
Lines 14806 14813 +7
Branches 4193 4206 +13
=======================================
+ Hits 14626 14633 +7
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 825 825
Lines 14806 14813 +7
Branches 4193 4198 +5
=======================================
+ Hits 14626 14633 +7
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.78% 98.78%
=======================================
Files 825 825
Lines 14806 14813 +7
Branches 4193 4198 +5
=======================================
+ Hits 14626 14633 +7
Misses 171 171
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
calvin-codecov
force-pushed
the
cy/no_tokenless_banner_signed_out
branch
from
470b463 to
ef1d10b
Compare
Bundle ReportChanges will increase total bundle size by 44 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
|
calvin-codecov
force-pushed
the
cy/no_tokenless_banner_signed_out
branch
from
305c884 to
245aff2
Compare
calvin-codecov
force-pushed
the
cy/no_tokenless_banner_signed_out
branch
from
245aff2 to
205f7c5
Compare
nicholas-codecov
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes codecov/engineering-team#3009
Only show banner if user is logged in.
Screenshots
Logged in:
Logged out:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.