Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staticEmberSource to ember-cli-build.js #1873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohitpaulk
Copy link
Member

@rohitpaulk rohitpaulk commented Jun 18, 2024

Summary by CodeRabbit

  • New Features
    • Enabled static ember source configuration for improved build performance and stability.

Copy link
Contributor

coderabbitai bot commented Jun 18, 2024

Walkthrough

A new configuration option staticEmberSource has been added to ember-cli-build.js. This change enhances the build configuration by enabling a static version of the Ember source, joining existing static configurations for helpers, modifiers, and components. This update aims to streamline the development environment.

Changes

File Change Summary
ember-cli-build.js Added staticEmberSource: true to the configuration object.

Poem

In the heart of code, a tweak so bright,
staticEmberSource is our new delight.
Amidst helpers, mods, and components we steer,
A smoother build, we now revere.
🎉✨ Happy coding to all, year after year! 🚀🐇


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jun 18, 2024

Test Results

1 files  ±  0  1 errors  0 suites   - 1   0s ⏱️ - 11m 56s
0 tests  - 541  0 ✅  - 503  0 💤  - 35  0 ❌ ±0 
0 runs   - 556  0 ✅  - 515  0 💤  - 35  0 ❌  - 3 

For more details on these parsing errors, see this check.

Results for commit 9eb7ffa. ± Comparison against base commit 026231a.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 18, 2024

Bundle Report

Changes will increase total bundle size by 135.33kB ⬆️

Bundle name Size Change
client-array-push 26.33MB 135.33kB ⬆️

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
ember-cli-build.js (2)

Line range hint 1-1: Remove the redundant 'use strict' directive, as ES6 modules are automatically in strict mode.

- 'use strict';

Line range hint 19-139: Consider refactoring this function expression to an arrow function for improved readability and to align with modern JavaScript practices.

- module.exports = function (defaults) {
+ module.exports = (defaults) => {
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 026231a and 9eb7ffa.

Files selected for processing (1)
  • ember-cli-build.js (1 hunks)
Additional context used
Biome
ember-cli-build.js

[error] 1-1: Redundant use strict directive. (lint/suspicious/noRedundantUseStrict)

The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.


[error] 19-139: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)

Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.

Additional comments not posted (1)
ember-cli-build.js (1)

92-92: Configuration addition of staticEmberSource is consistent with existing static options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant