[CCAP 636], Implement ccms data storage #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
analoo
reviewed
Feb 4, 2025
| @@ -3,6 +3,7 @@ | |||
| import java.math.BigInteger; | |||
| import java.time.LocalDate; | |||
| import java.util.List; | |||
| import java.util.Optional; | |||
spokenbird
reviewed
Feb 4, 2025
| private final CountyRepository countyRepository; | ||
| private final ResourceOrganizationRepository resourceOrganizationRepository; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
This looks great, thanks for taking on the task of adding the repository for counties!
Just a small note here, I think the @Autowired is unnecessary here. Since there is only one constructor for the class, Spring should automatically perform constructor-based dependency injection.
mtodd-cfa
requested changes
Feb 6, 2025
mtodd-cfa
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
✍️ Description
📷 Design reference
✅ Completion tasks