-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCAP-78] - map applicant county #1141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c2afe8
to
58823d3
Compare
58823d3
to
66c86d8
Compare
mtodd-cfa
previously requested changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I requested a couple changes around the number conversion.
src/main/java/org/ilgcc/app/data/importer/CCMSDataServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ilgcc/app/data/importer/CCMSDataServiceImpl.java
Outdated
Show resolved
Hide resolved
enyia21
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I echo Morgan's statements. Otherwise it looks good
cram-cfa
previously requested changes
Feb 11, 2025
src/main/java/org/ilgcc/app/data/importer/CCMSDataServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ilgcc/app/data/importer/CCMSDataServiceImpl.java
Outdated
Show resolved
Hide resolved
analoo
commented
Feb 11, 2025
Addressed the issues.
cram-cfa
approved these changes
Feb 11, 2025
src/main/java/org/ilgcc/app/submission/actions/SetOrganizationIdAndCCRRName.java
Outdated
Show resolved
Hide resolved
4b26a34
to
f017966
Compare
f017966
to
6887524
Compare
mtodd-cfa
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Jira ticket
CCAP-78
βοΈ Description
Sets
ApplicantAddressCounty
at the same time as it sets organization idMaps applicant county to application
π· Design reference
β Completion tasks