Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCAP-78] - map applicant county #1141

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[CCAP-78] - map applicant county #1141

merged 4 commits into from
Feb 11, 2025

Conversation

analoo
Copy link
Contributor

@analoo analoo commented Feb 10, 2025

πŸ”— Jira ticket

CCAP-78

✍️ Description

Sets ApplicantAddressCounty at the same time as it sets organization id
Maps applicant county to application

πŸ“· Design reference

βœ… Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@github-actions github-actions bot requested a review from enyia21 February 10, 2025 20:48
@analoo analoo requested a review from anahar-cfa February 10, 2025 20:48
@analoo analoo changed the title Ccap 78 map applicant county [CCAP-78] - map applicant county Feb 10, 2025
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-78-map-appl-kmzxqj February 10, 2025 20:49 Inactive
@analoo analoo force-pushed the CCAP-78-map-applicant-county branch from 9c2afe8 to 58823d3 Compare February 10, 2025 20:51
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-78-map-appl-kmzxqj February 10, 2025 20:51 Inactive
@analoo analoo force-pushed the CCAP-78-map-applicant-county branch from 58823d3 to 66c86d8 Compare February 10, 2025 20:54
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-78-map-appl-kmzxqj February 10, 2025 20:54 Inactive
Copy link

@mtodd-cfa mtodd-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I requested a couple changes around the number conversion.

Copy link
Contributor

@enyia21 enyia21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I echo Morgan's statements. Otherwise it looks good

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-78-map-appl-kmzxqj February 11, 2025 18:26 Inactive
@analoo analoo requested review from cram-cfa and mtodd-cfa February 11, 2025 19:04
@analoo analoo dismissed stale reviews from cram-cfa and mtodd-cfa February 11, 2025 19:04

Addressed the issues.

@enyia21 enyia21 temporarily deployed to il-gcc-ccap-78-map-appl-kmzxqj February 11, 2025 19:05 Inactive
@analoo analoo force-pushed the CCAP-78-map-applicant-county branch from 4b26a34 to f017966 Compare February 11, 2025 22:00
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-78-map-appl-kmzxqj February 11, 2025 22:00 Inactive
@analoo analoo force-pushed the CCAP-78-map-applicant-county branch from f017966 to 6887524 Compare February 11, 2025 22:00
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-78-map-appl-kmzxqj February 11, 2025 22:00 Inactive
@analoo analoo merged commit 28aa3db into main Feb 11, 2025
5 checks passed
@analoo analoo deleted the CCAP-78-map-applicant-county branch February 11, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants