Updating children-ccap-start-date by updating the tests #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#187090179
#187090179
sree-cfa
force-pushed
the
update-children-ccap-start-date
branch
from
df72bb1 to
b49a1f4
Compare
sree-cfa
reviewed
Feb 26, 2024
|
|
||
| @Slf4j | ||
| @Component | ||
| public class ValidateChildrenCCAPStartDateWhenChildNotInChildCareWithProvider extends VerifyDate { |
There was a problem hiding this comment.
These two validate classes are pretty similar - I think we could just have 1 action that also checks for that "in care with provider" variable as well
There was a problem hiding this comment.
actually if we combine this validation, we could combine the html pages as well
There was a problem hiding this comment.
Yeah I tried that. I had trouble pulling the childInCare variable in so I moved to separating them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187090179
🔗 Pivotal Tracker ticket
✍️ Description
📷 Design reference
✅ Completion tasks