Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve code scanning finds #65

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Resolve code scanning finds #65

merged 1 commit into from
Feb 21, 2024

Conversation

sree-cfa
Copy link
Contributor

Resolving code-scanning finds

  • Clearing out some sample UBI
  • Removed unused local vars
  • Added @Override annotations
  • Simplified non-null primitives

@sree-cfa sree-cfa changed the title Resolve code scanning Resolve code scanning finds Feb 21, 2024
@sree-cfa
Removing sample UBI related code
0b7a7e5 
Removing empty password

Fixing non-null primitives

nitpick - fixing warning

removing ubi conditions

Adding override annotation

Unused local variables

Removing duplicate overrides

fixing artifact path
@sree-cfa sree-cfa force-pushed the resolve-code-scanning branch from bbee1eb to 0b7a7e5 Compare February 21, 2024 22:24
@sree-cfa sree-cfa marked this pull request as ready for review February 21, 2024 22:26
@cy-by cy-by self-requested a review February 21, 2024 23:05
cy-by
cy-by approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

@sree-cfa sree-cfa merged commit 648e59d into main Feb 21, 2024
5 checks passed
@sree-cfa sree-cfa deleted the resolve-code-scanning branch February 21, 2024 23:11
enyia21 pushed a commit that referenced this pull request Feb 23, 2024
@sree-cfa @enyia21
Resolve code scanning finds (#65)
d411676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cy-by cy-by cy-by approved these changes

Assignees

@sree-cfa sree-cfa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sree-cfa @cy-by