Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding children-ccap-other-ed screen #68

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Adding children-ccap-other-ed screen #68

merged 2 commits into from
Feb 26, 2024

Conversation

sree-cfa
Copy link
Contributor

@sree-cfa sree-cfa commented Feb 22, 2024

πŸ”— Pivotal Tracker ticket

PT#186822601

✍️ Description

Adding children-ccap-other-ed screen - client will only see screen if the current child is over 5 years old

πŸ“· Design reference

Figma
Screenshot 2024-02-22 at 2 38 56β€―PM

βœ… Completion tasks

  • Added relevant tests
  • Meets acceptance criteria
  • Added testing instructions to ticket

@sree-cfa sree-cfa marked this pull request as ready for review February 22, 2024 22:44
@cy-by cy-by self-requested a review February 22, 2024 23:21
Copy link
Contributor

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen looks good πŸ‘πŸ»

The only thing is that in the Figma file, there's logic on hiding this screen if the child is under 5 years old.

2024-02-22 at 17 27 06@2x

Though I don't see this mentioned in the acceptance criteria in the ticket.

@sree-cfa sree-cfa changed the title Adding children-ccap-other-ed screen πŸ– Adding children-ccap-other-ed screen Feb 23, 2024
@sree-cfa sree-cfa requested a review from cy-by February 23, 2024 16:32
Copy link
Contributor

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, works as I expected.

@sree-cfa sree-cfa merged commit a3928b2 into main Feb 26, 2024
4 checks passed
@sree-cfa sree-cfa deleted the children-other-ed branch February 26, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants