Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NJ 79 - add page to select income source for 1099-R retirement income #5529

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aloverso
Copy link
Contributor

@aloverso aloverso commented Feb 5, 2025

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/79

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Add page to select income source for each 1099-R

How to test?

  • Use Zeus_Two_1099R
  • (when running locally) use Flipper.enable(:show_retirement_ui) in rails console to enable the UI toggle
  • (in heroku) sign into admin hub, then in the heroku app, navigate to /en/hub/flipper/features and enable show_retirement_ui

Screenshots (for visual changes)

image
image

Copy link

github-actions bot commented Feb 5, 2025

Heroku app: https://gyr-review-app-5529-bc2100d11010.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5529 (optionally add --tail)

@aloverso aloverso changed the title NJ 79 - add page to select incoome source for 1099-R retirement income NJ 79 - add page to select income source for 1099-R retirement income Feb 6, 2025
Copy link
Contributor

@mmazanec22 mmazanec22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@jachan jachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to learn about Flipper! One question about the future of the state_specific_followup code.

@aloverso aloverso force-pushed the nj-79-exclude-non-applicable-retirement-income branch from 15f5e04 to 86b24ec Compare February 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants