ID Content Update #5531
Merged
ID Content Update #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 5, 2025 12:57
|
Heroku app: https://gyr-review-app-5531-1d98beb4b3d1.herokuapp.com/ |
added 2 commits
February 5, 2025 13:43
embarnard
approved these changes
Feb 10, 2025
config/locales/en.yml
Outdated
| title: | ||
| one: Did you make any out-of-state purchases in %{year} without paying sales tax? | ||
| other: Did you or your spouse make any out-of-state purchases in %{year} without paying sales tax? | ||
| unpaid_sales_use_tax_label_html: Please enter the <b>total amount of purchases</b> that didn’t have sales or use tax applied. | ||
| unpaid_sales_use_tax_label_html: Enter the <b>total amount of purchases</b> that didn’t have sales tax applied in %{year}. |
There was a problem hiding this comment.
Use strong tags instead of b tags. We usually try to avoid b tags as are listed as WCAG compliance Level A Errors. Screen readers do not normally announce these tags to the user. (source)
Suggested change
| unpaid_sales_use_tax_label_html: Enter the <b>total amount of purchases</b> that didn’t have sales tax applied in %{year}. | |
| unpaid_sales_use_tax_label_html: Enter the <strong>total amount of purchases</strong> that didn’t have sales tax applied in %{year}. |
config/locales/es.yml
Outdated
| title: | ||
| many: "¿Tú o tu cónyuge hiciste alguna compra fuera del estado en %{year} sin pagar impuestos sobre ventas?" | ||
| one: "¿Hiciste alguna compra fuera del estado en %{year} sin pagar impuestos sobre ventas?" | ||
| other: "¿Tú o tu cónyuge hiciste alguna compra fuera del estado en %{year} sin pagar impuestos sobre ventas?" | ||
| unpaid_sales_use_tax_label_html: Ingrese el <b>cantidad total de compras</b> a las que no se les aplicaron impuestos sobre las ventas o el uso. | ||
| unpaid_sales_use_tax_label_html: Ingresa la <b>cantidad total de compras</b> a las que no se les aplicaron impuestos sobre las ventas o el uso %{year}. |
There was a problem hiding this comment.
Suggested change
| unpaid_sales_use_tax_label_html: Ingresa la <b>cantidad total de compras</b> a las que no se les aplicaron impuestos sobre las ventas o el uso %{year}. | |
| unpaid_sales_use_tax_label_html: Ingresa la <strong>cantidad total de compras</strong> a las que no se les aplicaron impuestos sobre las ventas o el uso %{year}. |
added 2 commits
February 10, 2025 10:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?