Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1762 Fix query for existing intakes WITH direct file data; if intake with ssn exists, log in with that #5548

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

jenny-heath
Copy link
Contributor

@jenny-heath jenny-heath commented Feb 8, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • the query to find an existing intake on verification code controller was accidentally returning intakes that do not have direct file data (we think the intention was the opposite)
  • the sign in and redirect method was picking a random first intake to log in, but we should prioritize ones with an ssn (therefore, have done data import)

How to test?

  • Added one unit test for each change that failed before the change and passes after. Still feel like the general testing approach is not robust enough but a client was just reported to have this issue so it seems like maybe we should get a fix out and then look at making more code improvements later.

…ssn exists, log in with that

Co-authored-by: jey flores <[email protected]>
Copy link

github-actions bot commented Feb 8, 2025

Heroku app: https://gyr-review-app-5548-45a8cf27f920.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5548 (optionally add --tail)

@jenny-heath jenny-heath marked this pull request as ready for review February 10, 2025 22:16
Copy link
Contributor

@jnf jnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tests close the gap well!

@jenny-heath jenny-heath merged commit 50f2334 into main Feb 11, 2025
7 checks passed
@jenny-heath jenny-heath deleted the login-verification-code-loop-bug branch February 11, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants