Feature/add about page

[pthan1]

Description

• Link the footer to the About page
• Implement the About.js component

Fixes #189

Type of Change:

• Code
• User Interface

Code/Quality Assurance Only

• New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

• My PR follows the style guidelines of this project
• I have performed a self-review of my own code or materials

Code/Quality Assurance Only

• My changes generate no new warnings
• My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been published in downstream modules

[galbwe]

@pthan1 just a heads up, the main header and sub header render on top of each other when I view this

[pthan1]

Sorry, I was viewing on a larger screen. I just fixed it.

…

On Fri, Oct 22, 2021 at 10:04 PM Wes Galbraith ***@***.***> wrote: @pthan1 <https://github.com/pthan1> just a heads up, the main header and sub header render on top of each other when I view this [image: Screen Shot 2021-10-22 at 10 01 28 PM] <https://user-images.githubusercontent.com/20004072/138541821-e1f3ea85-b025-4d29-bbec-0c639bb24890.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#212 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATYI2RJNZQLUQ7PZBSQEAQ3UIIX3BANCNFSM5GQZAJDQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Philong Than

[galbwe]

Please run yarn format and yarn lint and make any requested changes.

[galbwe]

Can you run yarn format from the frontend directory? That will make the formatting consistent with the main branch and reduce the number of diffs.

While you are there, also run yarn lint and make any changes the linter suggests. That should get the linter check in github to pass.

[galbwe]

I think the <Link /> component is adding some funky styling to the <Button /> text.

One way around it is to remove the <Link /> component and use the useHistory hook to reroute. There might be a better way that explicitly styles the link, so I'm open to other approaches.

Suggested change

	<Link to="/about">
	<Button className={classes.aboutFooter}>About</Button>
	</Link>
	<Button className={classes.aboutFooter} onClick={() => history.push('/about')}>
	About
	</Button>

[pthan1]

I've had luck switching the <Link /> to a <NavLink className={classes.link} />. What do you think?

[galbwe]

It would be nice to have a link back to /home from /about.