add: new messages file with French translations #536
Conversation
|
As discussed Sept 23, please also move the position text to a placeholder in the |
src/messages.json
Outdated
| "ActionPanel.action.moveToNextStep": "Move Step {stepNumber} {stepActionName} after step {nextStepNumber} {nextStepActionName}", | ||
| "ActionPanel.action.moveToNextStep.disabled": "Move Step {stepNumber} {stepActionName}", | ||
| "ActionPanel.action.moveToNextStep.outOfLoop": "Move Step {stepNumber} {stepActionName} out of loop {loopLabel}", | ||
| "ActionPanel.action.moveToNextStep.withInLoop": "Move Step {stepNumber} {stepActionName} after step {nextStepNumber} {nextStepActionName} of loop {loopLabel}", |
There was a problem hiding this comment.
This is what we had in the spreadsheet, but "within" is one word. Could you please rename this to ActionPanel.action.moveToNextStep.withinLoop (lowercase "i" in withinLoop).
Please also update ActionPanel.action.moveToPreviousStep.withInLoop
| "ActionPanel.action.delete": "supprimer {stepNumber} {stepActionName}", | ||
| "ActionPanel.action.moveToNextStep": "remplacer l'étape {stepNumber} {stepActionName} {nextStepInfo}", | ||
| "ActionPanel.action.moveToPreviousStep": "remplacer l'étape {stepNumber} {stepActionName} {previousStepInfo}", | ||
| "ActionPanel.action.replace": "remplacer l'étape {stepNumber} {stepActionName} {selectedActionName}", |
There was a problem hiding this comment.
The French message for ActionPanel.action.replace hasn't been updated for the split into noSelectedAction and withSelectedAction
There was a problem hiding this comment.
Thanks @sbates-idrc for reviewing the changes, I didn't update French messages yet because we don't have French translations yet. I think it makes sense to update them all when we get the translations.
| "ActionPanel.selectedCommandName": "{selectedCommandName} avec action sélectionner", | ||
| "ActionPanel.action.delete": "supprimer {stepNumber} {stepActionName}", | ||
| "ActionPanel.action.moveToNextStep": "remplacer l'étape {stepNumber} {stepActionName} {nextStepInfo}", | ||
| "ActionPanel.action.moveToPreviousStep": "remplacer l'étape {stepNumber} {stepActionName} {previousStepInfo}", |
There was a problem hiding this comment.
The French messages for ActionPanel.action.moveToNextStep and ActionPanel.action.moveToPreviousStep haven't been updated following the nextStepInfo/previousStepInfo refactoring.
src/ProgramChangeController.test.js
Outdated
| expectedAnnouncementCommandType: string, | ||
| expectedAnnouncementCommand: string | ||
| expectedAnnouncementActionType: string, | ||
| expectedAnnouncementAction: string |
There was a problem hiding this comment.
Please use expectedAnnouncementActionName here to be consistent with the thing we are testing against (actionName)
|
The French message for |
No description provided.