Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intro to iOS] Assignment 2 - Review my app #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

srochiramani
Copy link

/cc @codepath

@codepathreview
Copy link

(Please create an issue for grading on your own fork for the next assignment 😄)

Nice work! The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

  • For the restaurant cell, nice work encapsulating the properties into the private class extension.
  • Note that you should resolve all the Auto Layout constraint warnings
  • Your filter cells aren't tracking their states properly. If you scroll them off the page, you can see that the selection status isn't being restored properly.
  • Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.

This was a challenging assignment, congrats on completing it successfully! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants