chore!: remove deprecated items from coder_workspace data source
#255
+107
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce The owner-related fields (`owner`, `owner_email`, `owner_id`, `owner_name`, `owner_oidc_access_token`, `owner_groups`, `owner_session_token`) in the workspace data source have been deprecated. This commit removes these fields from the codebase.
matifali
commented
Jul 4, 2024
| @@ -13,11 +13,51 @@ Use this data source to get information for the active workspace build. | |||
| ## Example Usage | |||
|
|
|||
| ```terraform | |||
There was a problem hiding this comment.
Elaborated example usage. If its too much happy to simply it.
| @@ -36,7 +34,7 @@ resource "coder_env" "git_author_name" { | |||
| } | |||
|
|
|||
| resource "coder_env" "git_author_email" { | |||
| agent_id = var.agent_id | |||
| agent_id = coder_agent.dev.id | |||
There was a problem hiding this comment.
there was no var defined so used the already defined agent.
Comment on lines
-81
to
-87
| "workspace.owner": `testing`, | ||
| "workspace.owner_email": `testing@coder\.com`, | ||
| "workspace.owner_groups": `\[\]`, | ||
| "workspace.owner_id": `[a-zA-Z0-9]+`, | ||
| "workspace.owner_name": `default`, | ||
| "workspace.owner_oidc_access_token": `^$`, // TODO: need a test OIDC integration | ||
| "workspace.owner_session_token": `[a-zA-Z0-9-]+`, |
There was a problem hiding this comment.
removed all owner related items from the integration test. We already have a separate integration test for coder_workspace_owner.
johnstcn
approved these changes
Jul 4, 2024
|
We will need to bump the major version after this change. |
mtojek
approved these changes
Jul 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The owner-related fields (
owner,owner_email,owner_id,owner_name,owner_oidc_access_token,owner_groups,owner_session_token) in the workspace data source have been deprecated. This commit removes these fields from the codebase.We should have done this before https://github.com/coder/terraform-provider-coder/releases/tag/v1.0.0
contributes to #250