Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL history and CODER_URL #200

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add URL history and CODER_URL #200

merged 2 commits into from
Jan 31, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jan 30, 2024

We default to the last used URL or CODER_URL, if set, and you can choose from a list of past URLs.

Closes #182.

In this screenshot the "prefilled" value is from CODER_URL and dev.coder.com is from a past connection.

screenshot

@code-asher code-asher force-pushed the asher/refactor-url-storage branch 2 times, most recently from e07eb26 to 093833d Compare January 30, 2024 21:41
@code-asher code-asher requested a review from Kira-Pilot January 31, 2024 07:20
@code-asher code-asher force-pushed the asher/refactor-url-storage branch from 093833d to 975af97 Compare January 31, 2024 07:22
We default to the last used URL or CODER_URL, if set.
@code-asher code-asher force-pushed the asher/refactor-url-storage branch from 975af97 to 54b38d6 Compare January 31, 2024 07:23
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions but approving so I'm not blocking you! Thanks for looking at this.

@code-asher code-asher merged commit 5054d75 into main Jan 31, 2024
2 checks passed
@code-asher code-asher deleted the asher/refactor-url-storage branch January 31, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL should not be required on login when it is predefined on global storage
2 participants