Prevent parallel refreshes #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/fix-refresh
branch
2 times, most recently
from
f52ad04 to
ffdc7df
Compare
code-asher
force-pushed
the
asher/fix-refresh
branch
2 times, most recently
from
32392e8 to
72e127e
Compare
While adding an automatic refresh I discovered it was easy to accidentally cause two refreshes to go off at the same time which causes some races.
code-asher
force-pushed
the
asher/fix-refresh
branch
from
72e127e to
b4f046b
Compare
Kira-Pilot
reviewed
Feb 1, 2024
Kira-Pilot
approved these changes
Feb 1, 2024
We have to check storage again, otherwise we are just checking the values we already checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding an automatic refresh I discovered it was easy to
accidentally cause two refreshes to go off at the same time which causes
some races.
Also added a minor tweak to pass in the URL instead of pulling from the
global state since that felt race-y too.