Improve fetching Coder binary #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/fetch-binary
branch
7 times, most recently
from
75ea0f9 to
52a99d1
Compare
- Add more logging (the main goal of this commit). - Break out parts specific to the binary and add tests for those parts. - Check the version before making the request. - Avoid deleting the old binary right away, mostly to make it possible to debug why the plugin thought it was invalid. It will be cleaned up on the next download, so at most we have one. - Clean up left-over temporary binaries too. - Validate downloaded binary. - Catch error on writing (for example if we are downloading the binary to a read-only location).
code-asher
force-pushed
the
asher/fetch-binary
branch
from
52a99d1 to
d7e485f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to debug why the plugin thought it was invalid. It will be cleaned up
on the next download, so at most we have one.
to a read-only location).
Related: Add option to disable downloading Coder binary even if out of date or missing #193