feat: Implement SpaceBindingRequest controller main logic #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancisc
requested review from
sbryzak,
xcoulon,
alexeykazakov,
MatousJobanek,
rajivnathan and
ranakan19
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 76.30% 76.30%
=======================================
Files 41 41
Lines 1819 1819
=======================================
Hits 1388 1388
Misses 385 385
Partials 46 46 |
This was referenced Aug 16, 2023
Merged
MatousJobanek
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Not sure if this is really needed. We usually store the helper function only for creating dummy objects and asserting them. You know - something that is really needed at multiple places or something that doesn't change too often.
But why not, we can also add the conditions if it make the code easier & shorter. Let's see it we will face any issues with maintaining it 👍
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test utilities for SpaceBindingRequest controller.
Those will be used in both host-operator controller unit tests and e2e tests for spacebindingrequests.
Jira: https://issues.redhat.com/browse/ASC-397
Related PRs: