enable pairing with branches from ksctl repository #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatousJobanek
requested review from
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
mfrancisc
reviewed
Aug 12, 2024
|
/retest |
|
mfrancisc
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Looks great 👍
Thanks a lot for creating this and for answering my comments!
minor note - maybe we could document somewhere these variables:
USE_INSTALLED_KSCTL=true would use the installed ksctl version
KSCTL_REPO_PATH=/my/local/path/to/ksctl/ would build your local version of ksctl
WDYT?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MatousJobanek
merged commit 74da2b9
into
codeready-toolchain:master
7 of 8 checks passed
sadlerap
added a commit
to sadlerap/infra-deployments
that referenced
this pull request
Aug 13, 2024
With [PR redhat-appstudio#1030] landing in toolchain-e2e, tests now will try to pair an open PR against toolchain-e2e with an open PR against [ksctl]. We're always going to run tests with the latest version of ksctl, so we should install it before deploying member-operator. [PR redhat-appstudio#1030]: codeready-toolchain/toolchain-e2e#1030 [ksctl]: https://github.com/kubesaw/ksctl/ Signed-off-by: Andy Sadler <[email protected]>
rhtap-qe-bots-2
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Aug 13, 2024
With [PR redhat-appstudio#1030] landing in toolchain-e2e, tests now will try to pair an open PR against toolchain-e2e with an open PR against [ksctl]. We're always going to run tests with the latest version of ksctl, so we should install it before deploying member-operator. [PR redhat-appstudio#1030]: codeready-toolchain/toolchain-e2e#1030 [ksctl]: https://github.com/kubesaw/ksctl/ Signed-off-by: Andy Sadler <[email protected]>
rhtap-qe-bots-2
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Aug 13, 2024
With [PR redhat-appstudio#1030] landing in toolchain-e2e, tests now will try to pair an open PR against toolchain-e2e with an open PR against [ksctl]. We're always going to run tests with the latest version of ksctl, so we should install it before deploying member-operator. [PR redhat-appstudio#1030]: codeready-toolchain/toolchain-e2e#1030 [ksctl]: https://github.com/kubesaw/ksctl/ Signed-off-by: Andy Sadler <[email protected]>
redhat-appstudio-qe-bot
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Aug 13, 2024
With [PR redhat-appstudio#1030] landing in toolchain-e2e, tests now will try to pair an open PR against toolchain-e2e with an open PR against [ksctl]. We're always going to run tests with the latest version of ksctl, so we should install it before deploying member-operator. [PR redhat-appstudio#1030]: codeready-toolchain/toolchain-e2e#1030 [ksctl]: https://github.com/kubesaw/ksctl/ Signed-off-by: Andy Sadler <[email protected]>
rhtap-qe-bots-2
pushed a commit
to redhat-appstudio-qe/infra-deployments
that referenced
this pull request
Aug 13, 2024
With [PR redhat-appstudio#1030] landing in toolchain-e2e, tests now will try to pair an open PR against toolchain-e2e with an open PR against [ksctl]. We're always going to run tests with the latest version of ksctl, so we should install it before deploying member-operator. [PR redhat-appstudio#1030]: codeready-toolchain/toolchain-e2e#1030 [ksctl]: https://github.com/kubesaw/ksctl/ Signed-off-by: Andy Sadler <[email protected]>
openshift-merge-bot bot
pushed a commit
to redhat-appstudio/infra-deployments
that referenced
this pull request
Aug 13, 2024
* install ksctl during kubesaw deployment With [PR #1030] landing in toolchain-e2e, tests now will try to pair an open PR against toolchain-e2e with an open PR against [ksctl]. We're always going to run tests with the latest version of ksctl, so we should install it before deploying member-operator. [PR #1030]: codeready-toolchain/toolchain-e2e#1030 [ksctl]: https://github.com/kubesaw/ksctl/ Signed-off-by: Andy Sadler <[email protected]> * install ksctl directly Signed-off-by: Andy Sadler <[email protected]> --------- Signed-off-by: Andy Sadler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the e2e test setup is increasingly dependent on ksctl commands, I introduced a possibility of pairing between toolchain-e2e and ksctl.
USE_INSTALLED_KSCTLorKSCTL_REPO_PATH. The UX can be changed later.paired PR kubesaw/ksctl#58 (expecting to fail when generating tier manifests)