add tests to check that SpaceProvisionerConfig is only ready when the underlying ToolchainCluster is ready #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the underlying ToolchainCluster is ready.
|
Skipping CI for Draft Pull Request. |
This was referenced May 16, 2024
…to spc-ready-only-when-tc-ready
the new ToolchainCluster becomes ready in due time.
…to spc-ready-only-when-tc-ready
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
to not ready state.
…to spc-ready-only-when-tc-ready
|
/retest |
1 similar comment
|
/retest |
|
/test e2e |
|
/retest |
…to spc-ready-only-when-tc-ready
|
/retest |
2 similar comments
|
/retest |
|
/retest |
in the AutomaticApprovalTest.
MatousJobanek
approved these changes
Jun 13, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, metlos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pdates of ToolchainCluster.
|
MatousJobanek
merged commit 2e9e8f8
into
codeready-toolchain:master
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check that SpaceProvisionerConfig is only ready when the underlying ToolchainCluster is ready.
Related PRs:
I just want to put this out for others to take a look. I'm not sure if the approach to testing the capacity manager is correct and therefore keeping it as a draft for the time being.