test: SANDBOX-629: refactor TestPromoteSpace

[rsoaresd]

Description

When we create standalone spaces, we sporadically face flakiness since we currently do not make sure that the SpaceBinding is created along with Space. So, when we create SpaceBinding in a loop with space, we sporadically face flakiness because the space binding controller does not find the space at time - because the space is deleted by the space controller since it did not find the SpaceBinding at time- and for that reason it will delete the SpaceBinding and it will be not found.

To avoid it, we can remove unnecessary standalone space creation, which is the case of the TestPromoteSpace test.

Job example :

    host.go:2284: failed to find SpaceBinding
        
    space.go:56: 
        	Error Trace:	/tmp/toolchain-e2e/testsupport/space/space.go:56
        	            				/tmp/toolchain-e2e/testsupport/space/space.go:25
        	            				/tmp/toolchain-e2e/test/e2e/parallel/space_test.go:256
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestPromoteSpace

Issue ticket number and link

SANDBOX-629

[mfrancisc]

Looks good 👍

I tried to propose a small variation.

[MatousJobanek]

looks good, just one suggestion for simplification

[mfrancisc]

Nice job 👍

Thanks for addressing my comments.

[rsoaresd]

/retest

SANDBOX-636

[rsoaresd]

/retest

failed to wait for importing imagestreamtags on ci-op-8bmc4s90/stable

[MatousJobanek]

Nice 👍

[rsoaresd]

/retest

failed to wait for importing imagestreamtags on ci-op-dkmxr6b0/pipeline:ocp-4.12-upi-installer:

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment