Skip to content

Commit

Permalink
Allowing APPID param and adding integration tests.
Browse files Browse the repository at this point in the history
In order to record the requests and not do them once again any time tests are executed, VCR + Webmock it's being used.

Also api_spec.rb file updated to use recorded requests.
  • Loading branch information
yonelacort committed Aug 28, 2014
1 parent 2754893 commit 2cb77c7
Show file tree
Hide file tree
Showing 31 changed files with 1,133 additions and 57 deletions.
3 changes: 3 additions & 0 deletions .rspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
--color
--require spec_helper
--format documentation
2 changes: 2 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
source 'http://rubygems.org'

gem 'rspec'
gem 'vcr'
gem 'webmock'
10 changes: 10 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
GEM
remote: http://rubygems.org/
specs:
addressable (2.3.6)
crack (0.4.2)
safe_yaml (~> 1.0.0)
diff-lcs (1.2.2)
rspec (2.13.0)
rspec-core (~> 2.13.0)
Expand All @@ -10,9 +13,16 @@ GEM
rspec-expectations (2.13.0)
diff-lcs (>= 1.1.3, < 2.0)
rspec-mocks (2.13.0)
safe_yaml (1.0.3)
vcr (2.9.2)
webmock (1.18.0)
addressable (>= 2.3.6)
crack (>= 0.3.2)

PLATFORMS
ruby

DEPENDENCIES
rspec
vcr
webmock
2 changes: 1 addition & 1 deletion lib/open_weather/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def success?
private

def extract_options!(options)
valid_options = [:lat, :lon, :city, :country, :id, :units]
valid_options = [:lat, :lon, :city, :country, :id, :units, :APPID]
options.keys.each { |k| options.delete(k) unless valid_options.include?(k) }

if options[:city] || options[:country]
Expand Down
2 changes: 1 addition & 1 deletion lib/open_weather/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module OpenWeather
VERSION = "0.9.2"
VERSION = "0.10.0"
end
2 changes: 2 additions & 0 deletions open_weather.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,7 @@ Gem::Specification.new do |gem|
gem.executables = gem.files.grep(/^bin/).map{ |f| File.basename(f) }
gem.require_paths = ["lib"]
gem.add_development_dependency "rspec"
gem.add_development_dependency "vcr"
gem.add_development_dependency "webmock"
gem.add_runtime_dependency 'json'
end
47 changes: 47 additions & 0 deletions spec/fixtures/cassettes/api/current_city_id_invalid.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions spec/fixtures/cassettes/api/current_city_id_valid.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions spec/fixtures/cassettes/api/current_city_imperial_valid.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions spec/fixtures/cassettes/api/current_city_invalid.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions spec/fixtures/cassettes/api/current_city_metric_valid.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions spec/fixtures/cassettes/api/current_city_valid.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions spec/fixtures/cassettes/api/current_geocode_invalid.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2cb77c7

Please sign in to comment.