Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I270 install on device banner UI update #280

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

ChantelleKerr
Copy link
Contributor

@ChantelleKerr ChantelleKerr commented Jul 25, 2023

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

  • Updated UI on banner to install as PWA

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related Issue

@ChantelleKerr ChantelleKerr self-assigned this Jul 25, 2023
@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stride-for-education ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 0:44am

@RadioArsenic
Copy link
Member

Tried laptop, phone, and ipad and clearing all sorts of data, still haven't gotten install button to show up. Do think it's a me problem though

@HuxleyBerry
Copy link
Member

FWIW, the install button is present and works for me

@ChantelleKerr
Copy link
Contributor Author

ChantelleKerr commented Jul 26, 2023

It works for Jack, Dylan, Danish, James and Nick. I think its good to merge. Looks like its just a you and me problem xD

Copy link
Member

@RadioArsenic RadioArsenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good enough for me

@ChantelleKerr ChantelleKerr merged commit f39dd10 into main Jul 26, 2023
7 checks passed
@ChantelleKerr ChantelleKerr deleted the i270-install_on_device_banner_ui_update branch July 26, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install on device banner UI update
3 participants