Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 100 view and delete functionality all table list #105

Conversation

loklokyx
Copy link
Contributor

@loklokyx loklokyx commented Jan 30, 2025

Change Summary

  • feat(hooks): implement use-put-data hook
  • feat(hooks): implement use-delete-data hook
  • View, Edit, Delete for School & Team

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • [Y] The pull request title has an issue number
  • [Y] The change works by "Smoke testing" or quick testing
  • [N] The change has tests
  • [Y] The change has documentation

Related issue

- feat(hooks): implement `use-put-data` hook for handling PUT requests
- feat(hooks): implement `use-delete-data` hook for handling DELETE requests
… issue-100-View_and_Delete_Functionality_All_Table_List
… issue-100-View_and_Delete_Functionality_All_Table_List
- feat: add View, Edit, and Delete functionality in Test Management for School & Team pages
- refactor: clean up code and ensure request/response data matches API structure
@loklokyx loklokyx requested review from Chloeiw and leonleerl January 30, 2025 15:10
@loklokyx loklokyx self-assigned this Jan 30, 2025
@yunho7687
Copy link
Member

yo, could you please remove the login password verifying in user.ts (line 96-99)
I think that to check password when login is unnecessary.

Screenshot 2025-01-30 at 11 16 54 PM

Copy link
Member

@yunho7687 yunho7687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the login password verifying in user.ts

- remove password verification schema
- update validation to require at least one character
@loklokyx
Copy link
Contributor Author

please remove the login password verifying in user.ts

Done commit as requested.

@loklokyx loklokyx requested a review from yunho7687 January 30, 2025 15:26
@loklokyx loklokyx merged commit ea922de into issue-86-Invoke_Question_RESTful_API_from_backend Jan 31, 2025
5 checks passed
@loklokyx loklokyx deleted the issue-100-View_and_Delete_Functionality_All_Table_List branch January 31, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants