Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 120 create question management admin #132

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Issue 120 create question management admin #132

merged 5 commits into from
Feb 12, 2025

Conversation

leonleerl
Copy link
Contributor

@leonleerl leonleerl commented Feb 11, 2025 •
edited by github-actions bot
Loading

Change Summary

  1. Remove form validation for Category
  2. Remove asterisk from Category
  3. Rename the frontend interface name to match API
  4. Add image layout and scroll area for dialog

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • [Y] The pull request title has an issue number
  • [NA] The change works by "Smoke testing" or quick testing
  • [Y] The change has tests
  • [Y] The change has documentation

Related issue

@leonleerl leonleerl added the frontend Task must have a front end issue label Feb 11, 2025
@leonleerl leonleerl self-assigned this Feb 11, 2025
loklokyx
loklokyx approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@loklokyx loklokyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts resolved. Looks good now.

yunho7687
yunho7687 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@yunho7687 yunho7687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@loklokyx loklokyx merged commit d31fd81 into main Feb 12, 2025
5 checks passed
@loklokyx loklokyx deleted the issue-120-Create_Question_Management_-_ADMIN branch February 12, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunho7687 yunho7687 yunho7687 approved these changes

@loklokyx loklokyx loklokyx approved these changes

@Julie-Salazar Julie-Salazar Awaiting requested review from Julie-Salazar

@AarifLamat AarifLamat Awaiting requested review from AarifLamat

@Chloeiw Chloeiw Awaiting requested review from Chloeiw

Assignees

@leonleerl leonleerl

Labels
frontend Task must have a front end issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Question Management - ADMIN
3 participants
@leonleerl @yunho7687 @loklokyx